Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neos jp character fix #7

Merged
merged 2 commits into from
Nov 14, 2021
Merged

Neos jp character fix #7

merged 2 commits into from
Nov 14, 2021

Conversation

Earthmark
Copy link
Owner

The fix for the character as defined in Neos-Metaverse/NeosPublic#621 , this PR can be used to test the fix.

@Earthmark
Merged in the fixes from the library author, and removed an extra col…
b2cac8f 
…or inversion as the distance sign correction fixes this already.
@Earthmark Earthmark mentioned this pull request Nov 13, 2021
Open
@Earthmark
Copy link
Owner Author

Thank you for the warning, I'll update the base PR to not do the distance check. Right now the scanline check does appear to be needed, as there's another glyph that has issues without that pass.

The goal right now is to update and correct the problematic character without regressions. In this case I think even if the end quality is slightly lower, not breaking any existing characters is slightly more important.

If it helps, this is the character that currently seems to require scanline correction to fix, it's a u from the wizzta font:

{
	21, 2.63247871399;
		c(19.8034210205, 1.19658124447);
	18.6068382263, 0.538461565971;
		c(17.5897426605, -0.0598290637136);
	16.3333339691, 0.0598290637136;
		c(15.0769233704, 0.17948718369);
	14.0598297119, 1.97435891628;
		m(12.6837615967, 1.19658124447);
	11.1282052994, 0.658119678497;
		m(9.63247966766, 0.119658127427);
	8.1367521286, 0.0598290637136;
		m(6.64102602005, 0);
	5.26495742798, 0.538461565971;
		m(3.88888907433, 1.13675224781);
	2.93162417412, 2.57264971733;
		m(2.27350449562, 3.52991485596);
	2.09401702881, 4.90598297119;
		m(1.91453003883, 6.28205156326);
	1.91453003883, 7.77777814865;
		m(1.97435891628, 9.33333301544);
	2.03418803215, 10.8290605545;
		m(2.15384626389, 12.3846158981);
	2.09401702881, 13.6410264969;
		m(2.09401702881, 14.897436142);
	1.7948718071, 15.6752147675;
		m(1.55555558205, 16.5128211975);
	0.777777791023, 16.6324806213;
		y(0.71794873476, 16.6324806213);
	0.35897436738, 16.7521362305;
		y;
	0, 16.8717956543;
		c(3.05128216743, 18.7863254547);
	4.54700899124, 18.1282043457;
		c(6.10256433487, 17.4700870514);
	6.16239356995, 13.8803424835;
		c(6.16239356995, 12.6239318848);
	6.10256433487, 11.0683765411;
		c(6.04273509979, 9.57264995575);
	6.04273509979, 8.07692337036;
		c(6.10256433487, 6.58119678497);
	6.40171003342, 5.32478618622;
		c(6.70085477829, 4.0683760643);
	7.4786324501, 3.41025662422;
		c(8.25641059875, 2.75213694572);
	9.63247966766, 2.93162417412;
		c(11.0683765411, 3.11111116409);
	13.3418807983, 4.42735052109;
		m;
	13.3418807983, 12.5042734146;
		m(13.2222232819, 14.4188041687);
	12.8034200668, 15.5555562973;
		m(12.3846158981, 16.7521362305);
	10.6495723724, 16.7521362305;
		y(11.6068382263, 17.5897426605);
	12.2051286697, 17.9487190247;
		y(12.8034200668, 18.3076934814);
	13.5213680267, 18.367521286;
		y(15.3760681152, 18.4273529053);
	16.1538467407, 17.3504276276;
		y(16.9316253662, 16.3333339691);
	17.1111125946, 14.7179489136;
		y(17.3504276276, 13.1025648117);
	17.1709403992, 11.1880340576;
		y(17.0512828827, 9.33333301544);
	17.0512828827, 7.77777814865;
		y(17.0512828827, 5.08547019958);
	17.6495742798, 3.88888907433;
		y(18.2478637695, 2.75213694572);
	19.025642395, 2.4529914856;
		y(19.8632488251, 2.09401702881);
	21, 2.4529914856;
		m;
	#
}

@Earthmark
Copy link
Owner Author

I'm going to merge this into the neos version update, Kazu has also verified this and I've yet to see novel artifacts in fonts I've seen used.

@Earthmark Earthmark merged commit b5c3496 into neos_update Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Earthmark @Chlumsky